[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb
Subject:    Re: ub: drop BUG() and update small things
From:       Greg KH <greg () kroah ! com>
Date:       2008-03-21 22:47:52
Message-ID: 20080321224752.GA7944 () kroah ! com
[Download RAW message or body]

On Fri, Mar 21, 2008 at 03:29:48PM -0700, Pete Zaitcev wrote:
> On Thu, 20 Mar 2008 10:42:06 -0700, Chris Wedgwood <cw@f00f.org> wrote:
> 
> > > - Remove the BUG() which trips, borrow the code from scsi_end_request().
> 
> > I just test this now.  I'm still getting scsi_id stuck in D:
> 
> >   [<ffffffff80539653>] wait_for_completion+0x18/0x1a
> >   [<ffffffff80374735>] blk_execute_rq+0xc8/0xea
> >   [<ffffffff80377793>] sg_io+0x24c/0x35c
> >   [<ffffffff80377a7d>] scsi_cmd_ioctl+0x1da/0x3a9
> >   [<ffffffff803ee55b>] ub_bd_ioctl+0x2a/0x2c
> 
> Oh crap. Please try the attached (against the normal Linus tree).
> This time I had your hang reproduced and thus fixed.
> 
> Greg accepted my patch into his tree a few minutes ago, I'll have
> to post an update to update which fixes it for good.

"few minutes" == "yesterday sometime" ?  :)

You can always just send me a patch saying, "drop the patch called
foo.patch in place of this", no need to send updates.

Remember, I use quilt, it rocks for stuff like normal patch work :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]