[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb
Subject:    Re: ub: drop BUG() and update small things
From:       Chris Wedgwood <cw () f00f ! org>
Date:       2008-03-20 17:42:06
Message-ID: 20080320174206.GA3091 () puku ! stupidest ! org
[Download RAW message or body]

On Wed, Mar 19, 2008 at 04:55:41PM -0700, Pete Zaitcev wrote:

> - Remove the BUG() which trips, borrow the code from scsi_end_request().
>   This may break CD burning, because I am not sure residue gets returned
>   to cdrecord for successful commands. But everything that's good for SCSI
>   should be good for everyone else, right?
> - Ignore improper USB level residue. Too many devices have this bug.
> - Update cosmetics: spelling, formatting

I just test this now.  I'm still getting scsi_id stuck in D:

 scsi_id D ffff810001011180 5856 2830 1
  ffff810073273918 0000000000000082 0000000000000001 ffff81007e8be1c0
  ffff8100732738b8 ffff8100732738c8 ffff8100732738d8 ffffffff80755180
  ffffffff80755180 ffffffff80752260 ffffffff80755180 ffff8100731eee88
 Call Trace:
  [<ffffffff80539e08>] schedule_timeout+0x22/0xb4
  [<ffffffff8053bd32>] ? _spin_unlock_irq+0x26/0x2c
  [<ffffffff80539554>] wait_for_common+0xf6/0x16b
  [<ffffffff8022a60d>] ? default_wake_function+0x0/0xf
  [<ffffffff8053bd32>] ? _spin_unlock_irq+0x26/0x2c
  [<ffffffff80539653>] wait_for_completion+0x18/0x1a
  [<ffffffff80374735>] blk_execute_rq+0xc8/0xea
  [<ffffffff80377793>] sg_io+0x24c/0x35c
  [<ffffffff80377a7d>] scsi_cmd_ioctl+0x1da/0x3a9
  [<ffffffff8022a60d>] ? default_wake_function+0x0/0xf
  [<ffffffff803ee55b>] ub_bd_ioctl+0x2a/0x2c
  [<ffffffff803755af>] blkdev_driver_ioctl+0x63/0x78
  [<ffffffff80375cc1>] blkdev_ioctl+0x6fd/0x724
  [<ffffffff8053ba26>] ? _spin_unlock+0x26/0x2a
  [<ffffffff802a4004>] ? blkdev_open+0x0/0x6a
  [<ffffffff802a403b>] ? blkdev_open+0x37/0x6a
  [<ffffffff8027da34>] ? __dentry_open+0x111/0x1c0
  [<ffffffff8027db7c>] ? nameidata_to_filp+0x2e/0x40
  [<ffffffff802a3348>] block_ioctl+0x1b/0x1f
  [<ffffffff8028aa36>] vfs_ioctl+0x2a/0x77
  [<ffffffff8028acde>] do_vfs_ioctl+0x25b/0x270
  [<ffffffff8028ad35>] sys_ioctl+0x42/0x65
  [<ffffffff8020b21b>] system_call_after_swapgs+0x7b/0x80
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]