[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-unionfs
Subject:    Re: [PATCH v2 01/19] fs: add two trivial lookup helpers
From:       Christian Brauner <brauner () kernel ! org>
Date:       2022-03-30 16:02:14
Message-ID: 20220330160214.acs4tegiomjn3amg () wittgenstein
[Download RAW message or body]

On Wed, Mar 30, 2022 at 05:25:32PM +0200, Christoph Hellwig wrote:
> > +
> > +/*
> > + * Like lookup_positive_unlocked() but takes a mount's idmapping into account.
> > + */
> 
> Can you add a real kerneldoc comment here instead of referring to
> another function that will hopefully be removed rather sooner than
> later?

Done.

> 
> > +struct dentry *lookup_one_unlocked(struct user_namespace *, const char *, struct \
> > dentry *, int); +struct dentry *lookup_one_positive_unlocked(struct \
> > user_namespace *, const char *, struct dentry *, int);
> 
> Please spellt out the parameter names and avoid the overy long lines.

Done.

> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!


[prev in list] [next in list] [prev in thread] [next in thread]