[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-tegra
Subject:    RE: [PATCH V3 2/3] dt-bindings: tegra: Add tegra210 AHCI
From:       Preetham Chandru <pchandru () nvidia ! com>
Date:       2017-05-24 4:56:26
Message-ID: a1ff059b14c145faad91889585e18843 () BGMAIL104 ! nvidia ! com
[Download RAW message or body]



>-----Original Message-----
>From: Mikko Perttunen [mailto:cyndis@kapsi.fi]
>Sent: Sunday, May 14, 2017 4:56 PM
>To: Preetham Chandru <pchandru@nvidia.com>; thierry.reding@gmail.com;
>tj@kernel.org
>Cc: tegra@vger.kernel.org; linux-ide@vger.kernel.org; Laxman Dewangan
><ldewangan@nvidia.com>; preetham260@gmail.com; Venu Byravarasu
><vbyravarasu@nvidia.com>; Pavan Kunapuli <pkunapuli@nvidia.com>; linux-
>tegra@vger.kernel.org
>Subject: Re: [PATCH V3 2/3] dt-bindings: tegra: Add tegra210 AHCI
>
>On 05/12/2017 12:55 PM, Preetham Chandru wrote:
>> +CC linux-tegra@vger.kernel.org
>>
>>> -----Original Message-----
>>> From: Preetham Chandru
>>> Sent: Friday, May 12, 2017 3:04 PM
>>> To: thierry.reding@gmail.com; tj@kernel.org
>>> Cc: tegra@vger.kernel.org; linux-ide@vger.kernel.org; Laxman Dewangan
>>> <ldewangan@nvidia.com>; preetham260@gmail.com; Venu Byravarasu
>>> <vbyravarasu@nvidia.com>; Pavan Kunapuli <pkunapuli@nvidia.com>;
>>> Preetham Chandru <pchandru@nvidia.com>
>>> Subject: [PATCH V3 2/3] dt-bindings: tegra: Add tegra210 AHCI
>>>
>>> From: Preetham Chandru R <pchandru@nvidia.com>
>>>
>
>This needs a commit message. Something simple, like "This adds bindings
>documentation for the AHCI controller on Tegra210." is fine.
>

Okay, will change it.

>>> Signed-off-by: Preetham Chandru R <pchandru@nvidia.com>
>>> ---
>>> v3:
>>> * Add AUX register.
>>> v2:
>>> * change cml1, pll_e and phy regulators as optional  for T210.
>>> ---
>>> .../bindings/ata/nvidia,tegra124-ahci.txt          | 45 +++++++++++++++-------
>>> 1 file changed, 31 insertions(+), 14 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt
>>> b/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt
>>> index 66c83c3..dc62dba 100644
>>> --- a/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt
>>> +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt
>>> @@ -1,32 +1,49 @@
>>> -Tegra124 SoC SATA AHCI controller
>>> +Tegra SoC SATA AHCI controller
>>>
>>> Required properties :
>>> -- compatible : For Tegra124, must contain "nvidia,tegra124-ahci".
>>> Otherwise,
>>> -  must contain '"nvidia,<chip>-ahci", "nvidia,tegra124-ahci"', where
>>> <chip>
>>> -  is tegra132.
>>> -- reg : Should contain 2 entries:
>>> +- compatible : Must be one of:
>>> +  - Tegra124 : "nvidia,tegra124-ahci"
>>> +  - Tegra210 : "nvidia,tegra210-ahci"
>>> +- reg : Should contain 3 entries:
>>>   - AHCI register set (SATA BAR5)
>>>   - SATA register set
>>> +  - AUX register set
>
>The AUX register set must be optional on Tegra124, as it was not required
>previously.
>

In current driver changes we are touching the devslp register to disable DevSlp
which is a part of AUX for both t124 and t210. By default the devslp is enabled
for T124 and T210. (Reset value is 1). I will add this aux register in T124 node as well.

>>> - interrupts : Defines the interrupt used by SATA
>>> - clocks : Must contain an entry for each entry in clock-names.
>>>   See ../clocks/clock-bindings.txt for details.
>>> - clock-names : Must include the following entries:
>>>   - sata
>>>   - sata-oob
>>> -  - cml1
>>> -  - pll_e
>>> - resets : Must contain an entry for each entry in reset-names.
>>>   See ../reset/reset.txt for details.
>>> - reset-names : Must include the following entries:
>>>   - sata
>>>   - sata-oob
>>> -  - sata-cold
>>> +  - For T124: sata-cold
>>> - phys : Must contain an entry for each entry in phy-names.
>>>   See ../phy/phy-bindings.txt for details.
>>> - phy-names : Must include the following entries:
>>> -  - sata-phy : XUSB PADCTL SATA PHY
>>> -- hvdd-supply : Defines the SATA HVDD regulator
>>> -- vddio-supply : Defines the SATA VDDIO regulator
>>> -- avdd-supply : Defines the SATA AVDD regulator
>>> -- target-5v-supply : Defines the SATA 5V power regulator
>>> -- target-12v-supply : Defines the SATA 12V power regulator
>>> +  - For T124:
>>> +    - sata-phy : XUSB PADCTL SATA PHY
>>> +  - For T210:
>>> +    - sata-0
>>> +- For T124:
>>> +  - hvdd-supply : Defines the SATA HVDD regulator
>>> +  - vddio-supply : Defines the SATA VDDIO regulator
>>> +  - avdd-supply : Defines the SATA AVDD regulator
>>> +  - target-5v-supply : Defines the SATA 5V power regulator
>
>This is missing the 12V supply regulator
>

Okay. Will add.
>>> +
>>> +Optional properties:
>>> +- clock-names :
>>> +  - cml1 :
>>> +    cml1 clock is required by phy so it is optional to define
>>> +    here as phy driver will be enabling this clock.
>>> +  - pll_e :
>>> +    pll_e is the parent of cml1 clock so it is optional to define
>>> +    here as phy driver will be enabling this clock.
>>> +- For T210:
>>> +  - l0-hvddio-sata-supply : Defines the SATA HVDDIO regulator
>>> +  - l0-dvddio-sata-supply : Defines the SATA DVDDIO regulator
>>> +  - hvdd-pex-pll-e-supply : Defines the PEX PLL_E regulator
>>> +  - dvdd-sata-pll-supply  : Defines the SATA PLL regulator
>>> +  - hvdd-sata-supply      : Defines the SATA HVDD regulator
>
>I don't think the driver currently has code to enable these regulators?
>

Yes, they will be enabled in uphy. Will remove here.
>>> --
>>> 2.1.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-tegra"
>> in the body of a message to majordomo@vger.kernel.org More majordomo
>> info at  http://vger.kernel.org/majordomo-info.html
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]