[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-tegra
Subject:    RE: [PATCH] i2c: busses: i2c-tegra: Using
From:       Varun Wadekar <vwadekar () nvidia ! com>
Date:       2011-03-28 11:21:38
Message-ID: EC245B9844DE6242B3F3C3BED1ECD10F6C3720C2EC () BGMAIL02 ! nvidia ! com
[Download RAW message or body]

> So does there mean we should change the /drivers/mfd/tps6586x.c ?
Yes, that seems a reasonable thing to do.

-----Original Message-----
From: Wei Ni 
Sent: Monday, March 28, 2011 3:26 PM
To: 'Colin Cross'
Cc: khali@linux-fr.org; ben-linux@fluff.org; snanda@chromium.org; \
                linux-tegra@vger.kernel.org; Varun Wadekar
Subject: RE: [PATCH] i2c: busses: i2c-tegra: Using suspend_noirq()/resume_noirq() for \
suspend/resume

Hi, Cross
Sorry, I made some confusion.
In my description for this upstream, I said the tps6586x_irq() will try to read \
register before i2c resume. In here, the tps6586x_irq() is from \
drivers/mfd/tps6586x.c, not drivers/rtc/rtc-tps6586x.c I had tried to add \
disable/enable in suspend/resume for this mfd tps6586x driver, it also can fix this \
issue. So does there mean we should change the /drivers/mfd/tps6586x.c ?

Thanks
Wei.

-----Original Message-----
From: ccross@google.com [mailto:ccross@google.com] On Behalf Of Colin Cross
Sent: Monday, March 28, 2011 3:05 PM
To: Wei Ni
Cc: khali@linux-fr.org; ben-linux@fluff.org; snanda@chromium.org; \
                linux-tegra@vger.kernel.org; Varun Wadekar
Subject: Re: [PATCH] i2c: busses: i2c-tegra: Using suspend_noirq()/resume_noirq() for \
suspend/resume

On Sun, Mar 27, 2011 at 11:59 PM, Wei Ni <wni@nvidia.com> wrote:
> Hi, Colin
> The irq in rtc-tps6586x is the alarm interrupt, I had tried to disable/enable it
> as you said, but the system couldn't be resumed by wakealarm.
> I think it's better to change the i2c-tegra.c

Disabling an interrupt does not prevent waking from suspend on that
interrupt if enable_irq_wake has also been called.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]