[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-spi
Subject:    Re: [PATCH v4 8/8] dmaengine: ste_dma40: Use new helpers from overflow.h
From:       Andy Shevchenko <andriy.shevchenko () linux ! intel ! com>
Date:       2024-02-29 14:53:48
Message-ID: ZeCafPgtU1FeyzJG () smile ! fi ! intel ! com
[Download RAW message or body]

On Thu, Feb 29, 2024 at 03:14:03PM +0100, Linus Walleij wrote:
> On Wed, Feb 28, 2024 at 9:49 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > We have two new helpers struct_size_with_data() and struct_data_pointer()
> > that we can utilize in d40_hw_detect_init(). Do it so.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Wow really neat! Much easier to read and understand the code like this.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks, but Kees has seems even better suggestion.

-- 
With Best Regards,
Andy Shevchenko



[prev in list] [next in list] [prev in thread] [next in thread]