[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-spi
Subject:    Re: [PATCH 0/1] spi: sc18is602: Add reset control via gpio pin.
From:       Mark Brown <broonie () kernel ! org>
Date:       2016-08-31 14:49:34
Message-ID: 20160831144934.GA5967 () sirena ! org ! uk
[Download RAW message or body]

On Wed, Aug 31, 2016 at 03:31:37PM +0800, Phil Reid wrote:
> I didn't not check for null on devm_gpiod_get_optional as gpiod_set_value
> does this on entry. Frequency of this seemed low enough that the function
> call doesn't add any significant overhead. I can add a check if required.

Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff.  This reduces mail volume and ensures that 
any important information is recorded in the changelog rather than being
lost. 

["signature.asc" (application/pgp-signature)]
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]