[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-spi
Subject:    Re: [PATCH] spi: coldfire-qspi: Fix bits per word setting when t->bits_per_word is not set
From:       Mark Brown <broonie () kernel ! org>
Date:       2014-02-28 5:23:28
Message-ID: 20140228052328.GN9383 () sirena ! org ! uk
[Download RAW message or body]

On Thu, Feb 27, 2014 at 10:09:59AM -0700, Stephen Warren wrote:
> On 02/26/2014 06:05 PM, Axel Lin wrote:
> > This ensures to use spi_device's bits_per_word setting when t->bits_per_word is
> > not set. This looks like a bug introduced by commit 24778be20f8
> > "spi: convert drivers to use bits_per_word_mask".

> I thought the SPI core already contained this kind of logic, so that
> drivers could rely on t->bits_per_word always being set up? Yes, this:

Indeed - if there weren't such logic the better fix would be to add it.

["signature.asc" (application/pgp-signature)]
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]