[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sparse
Subject:    [patch 1/9] perf/x86/amd/uncore: Fix __percpu annotation
From:       Thomas Gleixner <tglx () linutronix ! de>
Date:       2024-03-04 10:12:18
Message-ID: 20240304005104.394845326 () linutronix ! de
[Download RAW message or body]

The __percpu annotation in struct amd_uncore is confusing sparse:

uncore.c:649:10: sparse: warning: incorrect type in initializer (different address spaces)
uncore.c:649:10: sparse:    expected void const [noderef] __percpu *__vpp_verify
uncore.c:649:10: sparse:    got union amd_uncore_info *

The reason is that the __percpu annotation sits between the '*'
dereferencing operator and the member name.

Move it before the dereferencing operator to cure this.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/events/amd/uncore.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/events/amd/uncore.c
+++ b/arch/x86/events/amd/uncore.c
@@ -71,7 +71,7 @@ union amd_uncore_info {
 };
 
 struct amd_uncore {
-	union amd_uncore_info * __percpu info;
+	union amd_uncore_info  __percpu *info;
 	struct amd_uncore_pmu *pmus;
 	unsigned int num_pmus;
 	bool init_done;


[prev in list] [next in list] [prev in thread] [next in thread]