[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sparse
Subject:    [PATCH 1/4] test-suite: remove bashism to avoid test failures
From:       Ramsay Jones <ramsay () ramsay1 ! demon ! co ! uk>
Date:       2014-10-11 19:56:16
Message-ID: 54398B60.9080009 () ramsay1 ! demon ! co ! uk
[Download RAW message or body]


The use of the '==' operator in a test/[ conditional is a non-POSIX
bash extension. In order to avoid test failures on systems that do
not have bash as the system shell (/bin/sh), replace the use of the
'==' operator with the POSIX compatible '=' operator.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Chris,

Sorry for not spotting this earlier; I just looked at your patch in
my email client and thought 'yep, that looks good', without actually
testing the change. :(

Since Linux Mint is a Ubuntu derivative my /bin/sh is actually dash.
(I hear Fedora are looking to change /bin/sh to dash as well. :-D ).

ATB,
Ramsay Jones

 validation/test-suite | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/validation/test-suite b/validation/test-suite
index 7f0f83e..df5a7c6 100755
--- a/validation/test-suite
+++ b/validation/test-suite
@@ -114,7 +114,7 @@ do_test()
 	set -- $cmd
 	base_cmd=`basename $1`
 	for i in $disabled_cmds; do
-		if [ "$i" == "$base_cmd" ] ; then
+		if [ "$i" = "$base_cmd" ] ; then
 			disabled_tests=`expr $disabled_tests + 1`
 			echo "     DISABLE $test_name ($file)"
 			return 3
-- 
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]