[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sparse
Subject:    Re: [PATCH] sparse: add __builtin_va_arg_pack() and __builtin_va_arg_pack_len()
From:       Christopher Li <sparse () chrisli ! org>
Date:       2013-07-19 2:49:59
Message-ID: CANeU7Qn5LFSKN9+vX+yGVovbcWNMmJT4HU6Se4ObsoJHh851fA () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jul 18, 2013 at 8:36 AM, Jeff Layton <jlayton@redhat.com> wrote:
> this patch stops sparse from complaining about them not being defined:
>
>     /usr/include/bits/stdio2.h:98:25: error: undefined identifier '__builtin_va_arg_pack'
>     /usr/include/bits/stdio2.h:98:25: error: not a function <noident>
>
> Probably, there is some better way to do this that actually validates
> this function, but I'm not clear on how to do it.
>

Please add a test case for the typical usage case of __buildin_va_arg_pack()
and __builtin_va_arg_pack_len(). At the very least, it needs to cover the real
world breakage that bother you enough to submit a patch.

The patch looks good otherwise.

Thanks

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]