[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sparse
Subject:    Re: [PATCH 5] Adding the NULL pointer checker.
From:       Linus Torvalds <torvalds () linux-foundation ! org>
Date:       2007-01-29 22:48:10
Message-ID: Pine.LNX.4.64.0701291446530.3611 () woody ! linux-foundation ! org
[Download RAW message or body]



On Mon, 29 Jan 2007, Chris Li wrote:

> > > --- sparse.orig/expand.c      2007-01-16 11:13:18.000000000 -0800
> > > +++ sparse/expand.c   2007-01-16 11:13:28.000000000 -0800
> > > -#define SELECT_COST 20               /* Cut-off for turning a conditional
> > into a select */
> > > -#define BRANCH_COST 10               /* Cost of a conditional branch */
> > > +#define SELECT_COST 0                /* Cut-off for turning a conditional
> > into a select */
> > > +#define BRANCH_COST 0                /* Cost of a conditional branch */
> > 
> > OK, I *think* that won't cause any harm.
> 
> Linus, any words here? I have a vague impression that it has some thing to
> do with simplifying phi usage, but I am not sure what is the real side effect.

I just think the old costs are likely more realistic, but they were pulled 
totally out of my *ss. 

If it's more convenient to set them to zero, go wild. No deep meaning.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]