[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sparc
Subject:    Re: [PATCH 1/3] sparc64: recognize and support sparc M8 cpu type
From:       David Miller <davem () davemloft ! net>
Date:       2017-07-23 6:35:31
Message-ID: 20170723.073531.1917446626045297636.davem () davemloft ! net
[Download RAW message or body]

From: Allen <allen.pais@oracle.com>
Date: Sat, 22 Jul 2017 14:26:25 +0530

> Sam/David,
>>
>> It is way better than the hardcoded values.
>> If the vales have any sort of name in the sparc specs
>> the values shall be prefixed with this.
>> Otherwise something like
>> CPU_ID_xxx
>>
>> And maybe add an intro comment like this:
>> /* following CPU_ID_xxx constants are used to identify the
>>   * CPU type in the setup phase (see xxx.S)
>> */
>>
> 
> Here's a quick diff. Let me know if this looks good to you guys. I'll
> send out the patch. I have tested this on a T4.

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]