[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sparc
Subject:    [patch 2.5][nit] fix uninitialized spinlock
From:       Pete Zaitcev <zaitcev () redhat ! com>
Date:       2003-04-12 4:53:59
[Download RAW message or body]

Dave, please consider for inclusion. Apparently, magic checking
trips it.

-- Pete

----- Forwarded message from Rob Radez <rob@osinvestor.com> -----

Date: Fri, 11 Apr 2003 23:33:44 -0400
From: Rob Radez <rob@osinvestor.com>
To: zaitcev@redhat.com
Subject: [patch 2.5][nit] fix uninitialized spinlock

This patch makes srmmu_context_spinlock and srmmu_nocache_spinlock
static and initializes srmmu_nocache_spinlock to unlocked.  Patch is
against 2.5.67 and is compile/boot tested.  I know, it's a minor thing
but it was an annoyance cluttering up my logs.

Regards,
Rob Radez

--- linux-2.5.67/arch/sparc/mm/srmmu.c.orig	2003-04-11 20:38:28.000000000 -0400
+++ linux-2.5.67/arch/sparc/mm/srmmu.c	2003-04-11 20:44:27.000000000 -0400
@@ -108,7 +108,7 @@
 ctxd_t *srmmu_context_table;
 
 int viking_mxcc_present;
-spinlock_t srmmu_context_spinlock = SPIN_LOCK_UNLOCKED;
+static spinlock_t srmmu_context_spinlock = SPIN_LOCK_UNLOCKED;
 
 int is_hypersparc;
 
@@ -152,7 +152,7 @@
 void *srmmu_nocache_bitmap;
 int srmmu_nocache_low;
 int srmmu_nocache_used;
-spinlock_t srmmu_nocache_spinlock;
+static spinlock_t srmmu_nocache_spinlock = SPIN_LOCK_UNLOCKED;
 
 /* This makes sense. Honest it does - Anton */
 #define __nocache_pa(VADDR) (((unsigned long)VADDR) - SRMMU_NOCACHE_VADDR + \
__pa((unsigned long)srmmu_nocache_pool))

----- End forwarded message -----
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]