[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-sound
Subject: Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec
From: Mark Brown <broonie () kernel ! org>
Date: 2024-05-17 11:11:43
Message-ID: 500db9de-6113-4e73-ba92-6e52ea292b32 () sirena ! org ! uk
[Download RAW message or body]
On Fri, May 17, 2024 at 05:05:41AM -0400, Elinor Montmasson wrote:
> From: "Mark Brown" <broonie@kernel.org>
> > This description (and the code) don't feel like they're actually generic
> > - they're clearly specific to the bidrectional S/PDIF case. I'd expect
> > something called -generic to cope with single CODECs as well as double,
> > and not to have any constraints on what those are.
> I proposed, in an reply of the v3 patch series to Krzysztof Kozlowski,
> the compatible "fsl,imx-audio-no-codec" instead of "generic".
> Krzysztof thought it was too generic, but it would convey more clearly
> that it is for cases without codec driver.
> Would this other compatible string be more appropriate ?
No. There is very clearly a CODEC here, it physically exists, we can
point at it on the board and it has a software representation. Your
code is also very specific to the two CODEC case.
["signature.asc" (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic