[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sound
Subject:    Re: [PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control
From:       Dennis Wassenberg <dennis.wassenberg () secunet ! com>
Date:       2016-12-19 11:05:27
Message-ID: 8ae41990-73e2-39cf-8d8b-f8b83f0dd996 () secunet ! com
[Download RAW message or body]

Hi Jiri,

On 19.12.2016 11:53, Jiri Kosina wrote:
> On Mon, 19 Dec 2016, Dennis Wassenberg wrote:
> 
> > "led_set_func_hid_lenovo" is set to "hid_lenovo_led_set"
> > 
> > +#if IS_ENABLED(CONFIG_HID_LENOVO)
> > +static int hda_fixup_thinkpad_hid_prepare(struct hda_codec *codec)
> > +{
> > +	struct hda_gen_spec *spec = codec->spec;
> > +	int ret = 0;
> > +
> > +	if (!is_thinkpad(codec))
> > +		return -ENODEV;
> > +	if (!led_set_func_hid_lenovo)
> > +		led_set_func_hid_lenovo = symbol_request(hid_lenovo_led_set);
> > 
> > "hid_lenovo_led_set" is introduced in "[PATCH v2 2/2] hda: 
> > thinkpad_helper: Add support for hid-lenovo LED control". This means 
> > that "[PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED 
> > control" can only work with applied "[PATCH 1/4] hid-lenovo: Add support 
> > for X1 Tablet cover special keys" and "[PATCH v2 2/2] hda: 
> > thinkpad_helper: Add support for hid-lenovo LED control".
> 
> Ah, okay, I wasn't aware of the other patchset. These two probably should 
> be merged together. Is the other 2-patch set merged in any tree already? 
> Where has it been submitted to?
> 
No 1/4, 2/4 and 3/4 are currently not merged to any tree. I reworked 1/4, 2/4 and 3/4 \
because of some comments from Benjamin Tissoires (mail from 14th September 2016).

The patches are submitted to all recipients at the To, CC-Line (e.g. linux-input \
mailing list).

Maybe I can merge 2/4 and 4/4 together. This is all for LED control. 1/4 is for \
key/input handling and 3/4 is a special FNLock handling where I should use a separate \
patch.

Currently I have no feedback regarding the reworked linux-input specific code. I hope \
I will get it soon :)

Best regards,

Dennis
--
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]