[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sound
Subject:    Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier
From:       Mark Rutland <mark.rutland () arm ! com>
Date:       2014-07-01 8:37:49
Message-ID: 20140701083749.GH28740 () leverpostej
[Download RAW message or body]

On Mon, Jun 30, 2014 at 10:43:42PM +0100, Mark Brown wrote:
> On Mon, Jun 30, 2014 at 06:21:15PM +0100, Mark Rutland wrote:
> > On Mon, Jun 30, 2014 at 06:10:59PM +0100, Dan Murphy wrote:
> 
> > > +Optional properties:
> 
> > > +- power-gpio - gpio pin to enable/disable the device
> 
> > The code below seems to look for "enable-gpio". Searching for
> > "power-gpio" only hits in the line above and the example below. I assume
> > the code is in error?
> 
> It depends what this is for - if it's for an external regulator it
> should be a regulator binding.  Also all GPIO properties
> are supposed to be called -gpios because DT conventions.

Sure. I was commenting on the mismatch between "enable" in the code and
"power" in the documentation rather than the appropriateness of either
"power-gpios" or "enable-gpios".

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]