[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sound
Subject:    Re: [PATCH 2/5] ASoC: wm8904: switch to CCF
From:       Mark Brown <broonie () kernel ! org>
Date:       2014-06-06 9:57:06
Message-ID: 20140606095706.GB2520 () sirena ! org ! uk
[Download RAW message or body]

On Thu, Jun 05, 2014 at 06:19:29PM +0800, Bo Shen wrote:

> +		if (wm8904->mclk)
> +			clk_prepare_enable(wm8904->mclk);

There's no point in having checks for MCLK here since...

> +	wm8904->mclk = devm_clk_get(&i2c->dev, "mclk");
> +	if (IS_ERR(wm8904->mclk)) {
> +		ret = PTR_ERR(wm8904->mclk);
> +		dev_err(&i2c->dev, "Failed to get MCLK\n");
> +		return ret;
> +	}

...we require a clock here.

["signature.asc" (application/pgp-signature)]
--
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]