[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-smp
Subject:    Re: MTRR patch v1.10
From:       David Wragg <dpw () doc ! ic ! ac ! uk>
Date:       1998-04-19 2:35:53
[Download RAW message or body]

Richard Gooch <Richard.Gooch@atnf.CSIRO.AU> writes:
> Changes since v1.9:
> 
> - Support for fixed MTRRs
>   Thanks to David Wragg <dpw@doc.ic.ac.uk>
> 
> - Better implementation of synchronisation of MTRRs across CPUs
>   Thanks to David Wragg <dpw@doc.ic.ac.uk>
> 
> Could people please give this a thorough testing. I plan on submitting
> this to Linus soon. I'm hoping that all people experiencing lockups
> with SMP machines (such as the GigaByte boards) will find the problems
> are fixed.

Also thanks to me was a bug causing misleading warnings on SMP in many
cases. They're harmless though.

Here's the fix, apply after mtrr-patch-1.10.gz

diff -ru linux-2.1.96.mtrr/arch/i386/kernel/mtrr.c linux-2.1.96.mod/arch/i386/kernel/mtrr.c
--- linux-2.1.96.mtrr/arch/i386/kernel/mtrr.c	Sun Apr 19 02:51:24 1998
+++ linux-2.1.96.mod/arch/i386/kernel/mtrr.c	Sun Apr 19 02:55:36 1998
@@ -351,7 +351,7 @@
 	changed = TRUE;
     }
 
-    rdmsr(MTRRphysBase_MSR(index), lo, hi); 
+    rdmsr(MTRRphysMask_MSR(index), lo, hi); 
 
     if ((vr->mask_lo & 0xfffff800UL) != (lo & 0xfffff800UL)
 	|| (vr->mask_hi & 0xfUL) != (hi & 0xfUL)) {

[prev in list] [next in list] [prev in thread] [next in thread]