[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-serial
Subject:    Re: [PATCH] vt: keyboard: Use led_set_brightness() in LED trigger activate() callback
From:       Jiri Slaby <jirislaby () kernel ! org>
Date:       2024-05-15 6:32:05
Message-ID: 57a9325d-b0d9-46ac-bb72-3f1ede7902f4 () kernel ! org
[Download RAW message or body]

On 11. 05. 24, 17:20, Hans de Goede wrote:
> A LED trigger's activate() callback gets called when the LED trigger
> gets activated for a specific LED, so that the trigger code can ensure
> the LED state matches the current state of the trigger condition.
> 
> led_trigger_event() is intended for trigger condition state changes and
> iterates over _all_ LEDs which are controlled by this trigger changing
> the brightness of each of them.
> 
> In the activate() case only the brightness of the LED which is being
> activated needs to change and that LED is passed as an argument to
> activate(), switch to led_set_brightness() to only change the brightness
> of the LED being activated.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

thanks,
-- 
js
suse labs


[prev in list] [next in list] [prev in thread] [next in thread]