[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-serial
Subject:    Re: [PATCH v3 0/3: rs485 fixes]
From:       Andy Shevchenko <andy.shevchenko () gmail ! com>
Date:       2017-07-31 9:30:54
Message-ID: CAHp75VcEZGUODCUQyEKCjaT4KgcmtnbMr-TcesN_5gwnrJf2TA () mail ! gmail ! com
[Download RAW message or body]

On Mon, Jul 31, 2017 at 11:46 AM, Rafael Gago <rafael.gago@gmail.com> wrote:
> [PATCH v3 1/2] serial: core: Consider rs485 settings to drive RTS
> [PATCH v3 2/2] serial: 8250: Use hrtimers for rs485 delays
>
> Sorry, this is my first submission.
>
> These patches fix two different rs485 issues and could (and maybe
> should) have been submitted separately, as they are independent.
>
> Changes in v2:
>   Due to a manual edit on the patch there was a typo (missing comma)
>   and the patch didn't compile. The Kernel build test robot caught
>   that.
>
> Changes in v3:
>   When resubmitting the patches on v2, the first patch wasn't
>   resubmitted.

There are few notices about this series:
1) in cover letter better to put changelog in reverse chronological
order (much faster to see what had been changed lately);
2) you have to include all parties who are interested in this, i.e.
subsystem maintainers (Greg KH), Matvey (IIRC his name correctly, you
may check this by running git annotate on the file);
3) might be something else, I need to go throught them to comment;

(and some advice)

4) don't forget to wait a bit to make a chance reviewers to comment;
5) in next iterations don't forget to Cc: the series to reviewers who
commented on previous one(s).


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]