[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-serial
Subject:    [RFC] serial_cs: remove noop
From:       Dominik Brodowski <linux () dominikbrodowski ! net>
Date:       2009-10-17 17:09:50
Message-ID: 20091017170950.GA23886 () comet ! dominikbrodowski ! net
[Download RAW message or body]


From: Dominik Brodowski <linux@dominikbrodowski.net>
Date: Sat, 17 Oct 2009 18:19:34 +0200
Subject: [PATCH 4/5] serial_cs: remove noop

In the only case "tuple" is used afterwards, tuple->DesiredTuple is
explicitely set to CISTPL_CFTABLE_ENTRY. Therefore, remove useless
assignments to other values.

CC: linux-serial@vger.kernel.org
CC: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
---
 drivers/serial/serial_cs.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/serial_cs.c b/drivers/serial/serial_cs.c
index ff4617e..47162d9 100644
--- a/drivers/serial/serial_cs.c
+++ b/drivers/serial/serial_cs.c
@@ -715,7 +715,6 @@ static int serial_config(struct pcmcia_device * link)
 	info->multi = (first_tuple(link, tuple, parse) == 0);
 
 	/* Is this a multiport card? */
-	tuple->DesiredTuple = CISTPL_MANFID;
 	info->manfid = link->manf_id;
 	info->prodid = link->card_id;
 
@@ -730,7 +729,6 @@ static int serial_config(struct pcmcia_device * link)
 
 	/* Another check for dual-serial cards: look for either serial or
 	   multifunction cards that ask for appropriate IO port ranges */
-	tuple->DesiredTuple = CISTPL_FUNCID;
 	if ((info->multi == 0) &&
 	    (link->has_func_id) &&
 	    ((link->func_id == CISTPL_FUNCID_MULTI) ||
-- 
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]