[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-sctp
Subject:    Re: [PATCH] [v2] net: sctp: fix skb leak in sctp_inq_free()
From:       Xin Long <lucien.xin () gmail ! com>
Date:       2024-02-13 15:21:53
Message-ID: CADvbK_cjg7kd7uFWxPBpwMAxwsuCki791zQ7D01y+vk0R5wTSQ () mail ! gmail ! com
[Download RAW message or body]

On Mon, Feb 12, 2024 at 7:25 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 12 Feb 2024 11:22:02 +0300 Dmitry Antipov wrote:
> > In case of GSO, 'chunk->skb' pointer may point to an entry from
> > fraglist created in 'sctp_packet_gso_append()'. To avoid freeing
> > random fraglist entry (and so undefined behavior and/or memory
> > leak), introduce 'sctp_chunk_release()' helper to ensure that
> > 'chunk->skb' is set to 'chunk->head_skb' (i.e. fraglist head)
> > before calling 'sctp_chunk_free()', and use the aforementioned
> > helper in 'sctp_inq_pop()' as well.
>
> Please repost this as a separate thread, per:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review
and instead of sctp_chunk_release(), please use a better name like
"sctp_inq_chunk_free()" when you repost.

Thanks.

> Xin Long is probably out for New Year celebrations, anyway.
> --
> pw-bot: cr

[prev in list] [next in list] [prev in thread] [next in thread]