[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH] firmware_loader: export sysctl registration
From:       Randy Dunlap <rdunlap () infradead ! org>
Date:       2021-11-30 22:59:36
Message-ID: 183b6172-c04e-42d9-00c5-d760c04f0b96 () infradead ! org
[Download RAW message or body]



On 11/30/21 08:45, Luis Chamberlain wrote:
> The firmware loader fallback sysctl table is always built-in,
> but when FW_LOADER=m the build will fail. We need to export
> the sysctl registration and de-registration. Use the private
> symbol namespace so that only the firmware loader uses these
> calls.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: firmware_loader: move firmware sysctl to its own files
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
> drivers/base/firmware_loader/fallback_table.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/base/firmware_loader/fallback_table.c \
> b/drivers/base/firmware_loader/fallback_table.c index 51751c46cdcf..255823887c70 \
>                 100644
> --- a/drivers/base/firmware_loader/fallback_table.c
> +++ b/drivers/base/firmware_loader/fallback_table.c
> @@ -56,10 +56,12 @@ int register_firmware_config_sysctl(void)
> 		return -ENOMEM;
> 	return 0;
> }
> +EXPORT_SYMBOL_NS_GPL(register_firmware_config_sysctl, FIRMWARE_LOADER_PRIVATE);
> 
> void unregister_firmware_config_sysctl(void)
> {
> 	unregister_sysctl_table(firmware_config_sysct_table_header);
> 	firmware_config_sysct_table_header = NULL;
> }
> +EXPORT_SYMBOL_NS_GPL(unregister_firmware_config_sysctl, FIRMWARE_LOADER_PRIVATE);
> #endif /* CONFIG_SYSCTL */
> 

-- 
~Randy


[prev in list] [next in list] [prev in thread] [next in thread]