[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH 05/11] pragma once: convert drivers/scsi/qla2xxx/qla_target.h
From:       Bart Van Assche <bvanassche () acm ! org>
Date:       2021-02-28 22:07:17
Message-ID: e617be2f-04cf-2ffb-50b8-9b7be31fb77a () acm ! org
[Download RAW message or body]

On 2/28/21 9:01 AM, Alexey Dobriyan wrote:
> This file has broken include guard which is not obvious just by looking
> at the code. Convert it manually. I think I got #endif right.

Why do you think that the include guard is broken? Please mention this
in the patch description.

> -
> -#ifndef __QLA_TARGET_H
> -#define __QLA_TARGET_H
> -
> +#pragma once
>  #include "qla_def.h"
>  #include "qla_dsd.h"

Please insert a blank line between #pragma once and the #include directives.

Thanks,

Bart.
[prev in list] [next in list] [prev in thread] [next in thread]