[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH 24/25] lpfc: Fix nvmet issues when link bounce under IO load
From:       Hannes Reinecke <hare () suse ! de>
Date:       2018-12-28 12:36:40
Message-ID: f802ba86-6e18-bb2c-ddea-2377a9958246 () suse ! de
[Download RAW message or body]

On 12/27/18 12:33 AM, James Smart wrote:
> Various null pointer dereference and general protection fault panics
> occur when there is a link bounce under load. There are a large number
> of "error" message 6413 indicating "bad release".
> 
> The issues resolve to list corruptions due to missing or inconsistent
> lock protection. Lockups are due to nested locks in the unsolicited
> abort path. The unsolicited abort path calls the wrong abort
> processing routine. There was also duplicate context release while
> aborts were still active in the hardware.
> 
> Removed duplicate locks and added lock protection around list item
> removal. Commonized lock handling around the abort processing routines.
> Prevent context release while still in ABTS list.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc_nvmet.c | 50 +++++++++++++++++++++++++++++++-----------
>   1 file changed, 37 insertions(+), 13 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
[prev in list] [next in list] [prev in thread] [next in thread]