[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH 14/25] lpfc: Allow override of hardware queue selection policies
From:       Hannes Reinecke <hare () suse ! de>
Date:       2018-12-28 9:23:40
Message-ID: 0f24470e-54b6-d90c-0d6f-8cd968616497 () suse ! de
[Download RAW message or body]

On 12/27/18 12:33 AM, James Smart wrote:
> Default behavior is to use the information from the upper io
> stacks to select the hardware queue to use for io submission.
> which typically has good cpu affinity.
> 
> However, the driver, when used on some variants of the upstream
> kernel, has found queuing information to be suboptimal for FCP
> or io completion locked on particular cpus.
> 
> For command submission situations, the lpfc_fcp_io_sched module
> parameter can be set to specify a hardware queue selection policy
> that overrides the os stack information.
> 
> For io completion situations, rather than queing cq processing
> based on the cpu servicing the interrupting event, schedule the
> cq processing on the cpu associated with the hardware queue's cq.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc_attr.c | 11 ++++++-----
>   drivers/scsi/lpfc/lpfc_hw4.h  |  2 +-
>   drivers/scsi/lpfc/lpfc_nvme.c | 14 +++++++++++---
>   drivers/scsi/lpfc/lpfc_scsi.c |  3 ++-
>   drivers/scsi/lpfc/lpfc_sli.c  |  2 +-
>   5 files changed, 21 insertions(+), 11 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes

[prev in list] [next in list] [prev in thread] [next in thread]