[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH] scsi_io_completion cleanup and fix CONDITION MET handling
From:       Douglas Gilbert <dgilbert () interlog ! com>
Date:       2018-02-27 16:33:18
Message-ID: 3c4fe888-58ff-716f-4c42-5f9591464004 () interlog ! com
[Download RAW message or body]

On 2018-02-27 05:00 AM, Johannes Thumshirn wrote:
> On Mon, 2018-02-26 at 13:48 -0500, Douglas Gilbert wrote:
>> Note: checkpatch.pl suggests that the BUG and BUG_ON macros be replaced
>> by WARN and WARN_ON . Perhaps others could comment on this.
> 
> Yes BUG() and BUG_ON() are usually a bad idea. Linus was even very eloquent
> about this in the SCSI Midlayer:  https://www.spinics.net/lists/linux-scsi/m
> sg105428.html
> 
> So please don't use it.
> 

I did not add them. I moved existing code into helper functions and then
checkpatch.pl and "blame" say that I own them.

However I can convert them to WARNs as the eloquent gentleman suggested.
v2 of patch coming.

Doug Gilbert
[prev in list] [next in list] [prev in thread] [next in thread]