[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH] bnx2fc: Fix check in SCSI completion handler when reqeust has already timed out.
From:       "Martin K. Petersen" <martin.petersen () oracle ! com>
Date:       2018-01-31 2:26:42
Message-ID: yq1o9lag3vh.fsf () oracle ! com
[Download RAW message or body]


Chad,

> When a request times out we set the io_req flag BNX2FC_FLAG_IO_COMPL so
> that if a subsequent completion comes in on that task ID we will ignore
> it.  The issue is that in the check for this flag there is a missing
> return so we will continue to process a request which may have already
> been returned to the ownership of the SCSI layer.  This can cause
> unpredictable results.

Applied to 4.16/scsi-fixes. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
[prev in list] [next in list] [prev in thread] [next in thread]