[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [RFC PATCH 1/9] scsi-ml: modify change_queue_depth to take in
From:       Mike Christie <michaelc () cs ! wisc ! edu>
Date:       2009-08-28 16:56:13
Message-ID: 4A980C2D.20707 () cs ! wisc ! edu
[Download RAW message or body]

Vasu Dev wrote:
> On Thu, 2009-08-27 at 12:21 +0200, Christof Schmitt wrote:
>> On Wed, Aug 26, 2009 at 11:03:20AM -0700, Vasu Dev wrote:
>>> --- a/include/scsi/scsi_host.h
>>> +++ b/include/scsi/scsi_host.h
>>> @@ -43,6 +43,13 @@ struct blk_queue_tags;
>>>  #define DISABLE_CLUSTERING 0
>>>  #define ENABLE_CLUSTERING 1
>>>
>>> +enum {
>>> +	SCSI_QDEPTH_SYSFS_REQ,	/* user requested change through sysfs */
>>> +	SCSI_QDEPTH_QFULL,	/* scsi-ml requested due to queue full */
>>> +	SCSI_QDEPTH_RAMP_UP,	/* scsi-ml requested due to threshhold event */
>>> +	SCSI_QDEPTH_RAMP_DOWN, 	/* LLD/class requested due to lld/class event */
>>> +};
>>> +
>>>  struct scsi_host_template {
>>>  	struct module *module;
>>>  	const char *name;
>> I did not find SCSI_QDEPTH_RAMP_DOWN being used. Would a LLD use this
>> internally when changing the queue depth?
>>
> 
> Yes it is not used, should be removed before final patches unless Mike
> have plan to use this reason code.
> 

It might have been a goof up on my part. It is not needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]