[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH 4/4] sd: misc checkpatch.pl fixes
From:       Bartlomiej Zolnierkiewicz <bzolnier () gmail ! com>
Date:       2009-04-29 20:46:12
Message-ID: 200904292246.12746.bzolnier () gmail ! com
[Download RAW message or body]

On Wednesday 29 April 2009 22:25:26 James Bottomley wrote:
> On Wed, 2009-04-29 at 22:09 +0200, Bartlomiej Zolnierkiewicz wrote:
> > Fix
> > 
> > 	ERROR: trailing whitespace
> > 	ERROR: code indent should use tabs where possible
> > 	WARNING: line over 80 characters
> > 	WARNING: braces {} are not necessary for single statement blocks
> > 	ERROR: switch and case should be at the same indent
> > 	ERROR: space required before the open parenthesis '('
> > 
> > issues detected by checkpatch.pl.
> > 
> > While at it:
> > - remove superfluous 'ret' local variable in sd_compat_ioctl()
> 
> I'd really rather not encourage pure whitespace fixing patches in
> SCSI ... we already know there's a lot of non conforming problems from a
> crufty code base ... at one patch per file it would take about 500
> patches and several thousand lines of review.

Well, we could at least fix the core code -- which means a lot less than
500 files...  However I see your point and I have no problem with keeping
the patch locally until it is more useful or you change your mind.

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]