[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-scsi
Subject:    Re: [PATCH] merge sd.h into sd.c and some cleanup
From:       Christoph Hellwig <hch () infradead ! org>
Date:       2002-10-27 14:51:42
[Download RAW message or body]

On Sun, Oct 27, 2002 at 10:22:03PM +1100, Douglas Gilbert wrote:
> The patch looks good. However ....
> The header file "sd.h" is included in quite a few lower level
> drivers in lk 2.5.44 (at least 55) and perhaps in a couple of
> other subsystems. The reason it is included is for the
> "biosparam" call in the API of lower level drivers. Whether
> it is still used or useful, I'm not sure. [It does seem
> quite unreasonable that lower level drivers need to include
> an upper level header.]

I've changed the biosparm API in the scsi BK tree, against which this
patch is (see http://linux-scsi.bkbits.net)

> You can drop my credit line (shown above) from sd.c . Perhaps
> James could make a "credits" file for everyone who has helped
> in the 2.5 scsi rework.

I think it's fine to keep it - I just had to shorten it to fit into
a ANSI terminal :)

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]