[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-s390
Subject:    Re: [PATCH 03/10] KVM: s390: factor out nullify_gisa()
From:       Janosch Frank <frankja () linux ! ibm ! com>
Date:       2018-10-31 8:25:12
Message-ID: 938101fc-0840-7270-68c7-00cdd150efb3 () linux ! ibm ! com
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 25.10.18 14:37, Michael Mueller wrote:
> This function will be used by the GIB alert handler and during
> the GISA clear operation. Thus it gets factored out here.
> 
> Signed-off-by: Michael Mueller <mimu@linux.ibm.com>
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>

Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

> ---
>  arch/s390/kvm/interrupt.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 3789a9ad8dee..ce258d6b7c06 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -2886,11 +2886,16 @@ int kvm_s390_get_irq_state(struct kvm_vcpu *vcpu, __u8 __user *buf, int len)
>  	return n;
>  }
>  
> +static void nullify_gisa(struct kvm_s390_gisa *gisa)
> +{
> +	memset(gisa, 0, sizeof(struct kvm_s390_gisa));
> +	gisa->next_alert = (u32)(u64)gisa;
> +}
> +
>  void kvm_s390_gisa_clear(struct kvm *kvm)
>  {
>  	if (kvm->arch.gisa) {
> -		memset(kvm->arch.gisa, 0, sizeof(struct kvm_s390_gisa));
> -		kvm->arch.gisa->next_alert = (u32)(u64)kvm->arch.gisa;
> +		nullify_gisa(kvm->arch.gisa);
>  		VM_EVENT(kvm, 3, "gisa 0x%pK cleared", kvm->arch.gisa);
>  	}
>  }
> 



["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]