[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-s390
Subject:    Re: [RFC] [Patch 1/4] statistics: no include hell for users
From:       Martin Peschke <mp3 () de ! ibm ! com>
Date:       2007-06-07 0:32:34
Message-ID: 46675222.9000304 () de ! ibm ! com
[Download RAW message or body]

Dave Hansen wrote:
> On Wed, 2007-06-06 at 23:33 +0200, Martin Peschke wrote:
>>  struct statistic_interface {
>>  /* private: */
>>         struct list_head         list;
>> -       struct dentry           *debugfs_dir;
>> -       struct dentry           *data_file;
>> -       struct dentry           *def_file;
>> +       void                    *debugfs_dir;
>> +       void                    *data_file;
>> +       void                    *def_file; 
> 
> If you don't actually dereference the pointer, you should just be able
> to declare:
> 
> 	struct dentry;
> 
> and be done with it, right?  You don't _need_ the includes to have just
> pointers.

Ah, looks like an established trick in kernel include files.
I guess I can revert the other, seq_file related change then as well.
Thank you. Will change my local copy.

Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]