[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-rtc
Subject: Re: [PATCH] rtc: remove 'pending' variable from mpfs_rtc_wakeup_irq_handler()
From: Alexandre Belloni <alexandre.belloni () bootlin ! com>
Date: 2022-07-26 14:22:50
Message-ID: 165884535076.3156642.16325816554140473959.b4-ty () bootlin ! com
[Download RAW message or body]
On Mon, 27 Jun 2022 16:59:43 -0400, Tom Rix wrote:
> cppcheck reports
> [drivers/rtc/rtc-mpfs.c:219]: (style) Variable 'pending' is assigned a value that is never used.
>
> The fetched CONTROL_REG stored in pending is unused and partially
> duplicates the functionality of the later call to mpfs_rtc_clear(). This looks
> like leftover development code, so remove pending.
>
> [...]
Applied, thanks!
[1/1] rtc: remove 'pending' variable from mpfs_rtc_wakeup_irq_handler()
commit: 3fa0cb37bda9d45d3c6f07e67051e7118d3ffe63
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic