[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rtc
Subject:    Re: [PATCH v2 2/7] mfd: max77686: Do not enforce (incorrect) interrupt trigger type
From:       Stephen Boyd <sboyd () kernel ! org>
Date:       2021-05-26 22:33:34
Message-ID: 162206841417.4130789.13945208806958598688 () swboyd ! mtv ! corp ! google ! com
[Download RAW message or body]

Quoting Krzysztof Kozlowski (2021-05-26 10:20:31)
> From: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Interrupt line can be configured on different hardware in different way,
> even inverted.  Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
> 
> The Maxim 77686 datasheet describes the interrupt line as active low
> with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
> 
> The interrupt line is shared between PMIC and RTC driver, so using level
> sensitive interrupt is here especially important to avoid races.  With
> an edge configuration in case if first PMIC signals interrupt followed
> shortly after by the RTC, the interrupt might not be yet cleared/acked
> thus the second one would not be noticed.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>
> 
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org> # clock binding
[prev in list] [next in list] [prev in thread] [next in thread]