[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rtc
Subject:    [PATCH] rtc: rtc-mrst: Replace mdelay() with msleep() in mrst_read_time()
From:       Jia-Ju Bai <baijiaju1990 () gmail ! com>
Date:       2018-07-30 13:59:03
Message-ID: 20180730135903.9442-1-baijiaju1990 () gmail ! com
[Download RAW message or body]

mrst_read_time() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 drivers/rtc/rtc-mrst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-mrst.c b/drivers/rtc/rtc-mrst.c
index fcb9de5218b2..e4015f70f9fe 100644
--- a/drivers/rtc/rtc-mrst.c
+++ b/drivers/rtc/rtc-mrst.c
@@ -91,7 +91,7 @@ static int mrst_read_time(struct device *dev, struct rtc_time *time)
 	unsigned long flags;
 
 	if (vrtc_is_updating())
-		mdelay(20);
+		msleep(20);
 
 	spin_lock_irqsave(&rtc_lock, flags);
 	time->tm_sec = vrtc_cmos_read(RTC_SECONDS);
-- 
2.17.0

[prev in list] [next in list] [prev in thread] [next in thread]