[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rt-users
Subject:    Re: [PATCH 3/4] rteval: Convert CpuList class to a module
From:       John Kacur <jkacur () redhat ! com>
Date:       2023-12-14 15:05:04
Message-ID: 6a2ffb2b-84c7-3667-7bf7-dd174f12c0f6 () redhat ! com
[Download RAW message or body]


On Thu, 14 Dec 2023, Tomas Glozar wrote:

> út 12. 12. 2023 v 22:46 odesílatel John Kacur <jkacur@redhat.com> napsal:
> >
> > You don't have to do it in this patch, but some builtin testing would be
> > nice under this
> > if __name__ == "__main__":
> >
> 
> Yeah that's definitely a good idea, moving the cpulist logic into a
> separate module will allow for more elegant unit tests directly in the
> file.
> 
> In the future, we might also consider moving tests into separate files
> using some kind of unit test library like pytest [1] or the builtin
> unit test [2] module. If I understand it correctly, currently you have
> to run tests manually for each module that has them, and you also have
> to check the results manually; changing that to a more systematic and
> automated approach should make development easier and prevent bugs.
> 
> [1] - https://docs.pytest.org/en/7.4.x/
> [2] - https://docs.python.org/3/library/unittest.html
> 
> Tomas

Indeed, that would be welcome, but I still wouldn't remove the 
quick and dirty tests that are already available.

John

[prev in list] [next in list] [prev in thread] [next in thread]