[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-renesas-soc
Subject:    Re: [PATCH v2] watchdog: rza_wdt: Use semicolons instead of commas
From:       Kieran Bingham <kieran.bingham () ideasonboard ! com>
Date:       2021-10-27 13:09:24
Message-ID: 163534016415.1184428.1151584448808244621 () Monstersaurus
[Download RAW message or body]

Quoting Geert Uytterhoeven (2021-10-27 13:36:03)
> This code works, but it is cleaner to use semicolons at the end of
> statements instead of commas.
> 
> Extracted from a big anonymous patch by Julia Lawall
> <julia.lawall@inria.fr>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Yikes, that's subtle, the fun you can have with valid C code ;-)

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
> v2:
>   - Add Reviewed-by.
> ---
>  drivers/watchdog/rza_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/rza_wdt.c b/drivers/watchdog/rza_wdt.c
> index 7b6c365f7cd36297..fe6c2ed35e04cc4b 100644
> --- a/drivers/watchdog/rza_wdt.c
> +++ b/drivers/watchdog/rza_wdt.c
> @@ -189,8 +189,8 @@ static int rza_wdt_probe(struct platform_device *pdev)
>                 return -ENOENT;
>         }
>  
> -       priv->wdev.info = &rza_wdt_ident,
> -       priv->wdev.ops = &rza_wdt_ops,
> +       priv->wdev.info = &rza_wdt_ident;
> +       priv->wdev.ops = &rza_wdt_ops;
>         priv->wdev.parent = dev;
>  
>         priv->cks = (u8)(uintptr_t) of_device_get_match_data(dev);
> -- 
> 2.25.1
>
[prev in list] [next in list] [prev in thread] [next in thread]