[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rdma
Subject:    Re: [PATCH v2] mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled
From:       "lizhijian () fujitsu ! com" <lizhijian () fujitsu ! com>
Date:       2021-08-30 9:30:42
Message-ID: 2d30c629-5169-1405-4f3e-03d630a99678 () fujitsu ! com
[Download RAW message or body]



On 30/08/2021 15:32, Christoph Hellwig wrote:
> On Sat, Aug 28, 2021 at 09:04:41AM +0800, Li Zhijian wrote:
>> +	if (!pte_devmap(pte) && pte_special(pte) &&
>> +	    !is_zero_pfn(pte_pfn(pte))) {
> Maybe this is a little too superficial and nitpicky, but I find the
> ordering of the checks a little strange.  Why not do the pte_special
> first and then the exlusions from it later?
>
It sounds good to me, let's update it

Thanks
Zhijian


[prev in list] [next in list] [prev in thread] [next in thread]