[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rdma
Subject:    Re: [PATCH 3/3] iser-target: Fix error path in isert_create_pi_ctx()
From:       Sagi Grimberg <sagig () dev ! mellanox ! co ! il>
Date:       2015-05-31 12:54:01
Message-ID: 556B0469.4080501 () dev ! mellanox ! co ! il
[Download RAW message or body]

On 5/30/2015 9:12 AM, Roland Dreier wrote:
> From: Roland Dreier <roland@purestorage.com>
>
> We don't assign pi_ctx to desc->pi_ctx until we're certain to succeed
> in the function.  That means the cleanup path should use the local
> pi_ctx variable, not desc->pi_ctx.
>
> This was detected by Coverity (CID 1260062).
>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
> ---
>   drivers/infiniband/ulp/isert/ib_isert.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index 327529ee85eb..3f40319a55da 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -547,11 +547,11 @@ isert_create_pi_ctx(struct fast_reg_descriptor *desc,
>   	return 0;
>
>   err_prot_mr:
> -	ib_dereg_mr(desc->pi_ctx->prot_mr);
> +	ib_dereg_mr(pi_ctx->prot_mr);
>   err_prot_frpl:
> -	ib_free_fast_reg_page_list(desc->pi_ctx->prot_frpl);
> +	ib_free_fast_reg_page_list(pi_ctx->prot_frpl);
>   err_pi_ctx:
> -	kfree(desc->pi_ctx);
> +	kfree(pi_ctx);
>
>   	return ret;
>   }
>

Acked-by: Sagi Grimberg <sagig@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]