[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rdma
Subject:    [PATCH opensm] osm_mcast_tbl.c: Wrong assert placement in osm_mcast_tbl_get_block
From:       Hal Rosenstock <hal () dev ! mellanox ! co ! il>
Date:       2015-05-29 12:47:52
Message-ID: 55685FF8.8000306 () dev ! mellanox ! co ! il
[Download RAW message or body]

From: Ilya Nelkenbaum <ilyan@mellanox.com>
Date: Mon, 28 Jan 2013 13:53:38 +0200

Signed-off-by: Ilya Nelkenbaum <ilyan@mellanox.com>
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
diff --git a/opensm/osm_mcast_tbl.c b/opensm/osm_mcast_tbl.c
index c4a64e2..617fd50 100644
--- a/opensm/osm_mcast_tbl.c
+++ b/opensm/osm_mcast_tbl.c
@@ -242,7 +242,6 @@ boolean_t osm_mcast_tbl_get_block(IN osm_mcast_tbl_t * p_tbl,
 
 	CL_ASSERT(p_tbl);
 	CL_ASSERT(p_block);
-	CL_ASSERT(block_num * IB_MCAST_BLOCK_SIZE <= p_tbl->mft_depth);
 
 	if (block_num > p_tbl->max_block_in_use)
 		return FALSE;
@@ -255,6 +254,8 @@ boolean_t osm_mcast_tbl_get_block(IN osm_mcast_tbl_t * p_tbl,
 		return TRUE;
 	}
 
+	CL_ASSERT(block_num * IB_MCAST_BLOCK_SIZE <= p_tbl->mft_depth);
+
 	mlid_start_ho = (uint16_t) (block_num * IB_MCAST_BLOCK_SIZE);
 
 	for (i = 0; i < IB_MCAST_BLOCK_SIZE; i++)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]