[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rdma
Subject:    Re: [PATCH 5/9] IB/ipoib: Use dedicated workqueues per interface
From:       Or Gerlitz <gerlitz.or () gmail ! com>
Date:       2015-02-23 16:48:54
Message-ID: CAJ3xEMggQCzn2LfuvjeinC9pFR7nFXRaxST-J-Pu_8wJSobogg () mail ! gmail ! com
[Download RAW message or body]

On Sun, Feb 22, 2015 at 2:27 AM, Doug Ledford <dledford@redhat.com> wrote:
> @@ -236,12 +247,19 @@ out_free_send_cq:
>  out_free_recv_cq:
>         ib_destroy_cq(priv->recv_cq);
>
> +out_cm_dev_cleanup:
> +       ipoib_cm_dev_cleanup(dev);
> +
> +out_free_wq:
> +       destroy_workqueue(priv->wq);
> +       priv->wq = NULL;
> +
>  out_free_mr:
>         ib_dereg_mr(priv->mr);
> -       ipoib_cm_dev_cleanup(dev);
>
>  out_free_pd:
>         ib_dealloc_pd(priv->pd);
> +
>         return -ENODEV;
>  }

just quick initial feedback to get fixed for V1 of the reworked
series: please avoid random addition/deletion of blank lines as part
of patch that fix bug X or introduce feature Y

>
> @@ -265,11 +283,18 @@ void ipoib_transport_dev_cleanup(struct net_device *dev)
>
>         ipoib_cm_dev_cleanup(dev);
>
> +       if (priv->wq) {
> +               flush_workqueue(priv->wq);
> +               destroy_workqueue(priv->wq);
> +               priv->wq = NULL;
> +       }
> +
>         if (ib_dereg_mr(priv->mr))
>                 ipoib_warn(priv, "ib_dereg_mr failed\n");
>
>         if (ib_dealloc_pd(priv->pd))
>                 ipoib_warn(priv, "ib_dealloc_pd failed\n");
> +
>  }

here too
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]