[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rdma
Subject:    Re: [PATCH v1 1/3] IB/core: Add support for extended query device caps
From:       Matan Barak <matanb () dev ! mellanox ! co ! il>
Date:       2015-02-22 9:56:20
Message-ID: CAAKD3BCFiQhTKLPURpb3FWT+qaGHicyEbJE2NByyuKAAA-8JvQ () mail ! gmail ! com
[Download RAW message or body]

On Sun, Feb 22, 2015 at 9:14 AM, Haggai Eran <haggaie@mellanox.com> wrote:
> On 19/02/2015 20:27, Jason Gunthorpe wrote:
>> On Thu, Feb 19, 2015 at 02:30:29PM +0200, Matan Barak wrote:
>>> > Furthermore, ibv_create_flow and ibv_destroy_flow were already
>>> > accepted using the old schema.
>> IIRC they didn't have values that could meaningfully be 0?
>
> I think they don't have any extension yet -- I don't see any change
> before 69ad5da41b4e ("IB/core: Re-enable create_flow/destroy_flow uverbs").
>
> They verify comp_mask == 0 on command entry, and create_flow zeros the
> response's comp_mask when it returns.

Correct, but they don't have the response_length field.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]