[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-rdma
Subject:    Re: [PATCH V8 libibverbs 1/7] Infrastructure to support verbs extensions
From:       Jason Gunthorpe <jgunthorpe () obsidianresearch ! com>
Date:       2013-07-31 16:52:05
Message-ID: 20130731165205.GC27845 () obsidianresearch ! com
[Download RAW message or body]

On Wed, Jul 31, 2013 at 10:27:06AM +0300, Yishai Hadas wrote:

>     Looking around ibv_context usage, it's used as non const input,
> in that case we can have only one version which takes non-const
> input and return non-const one, preventing any silent casting as
> below, can we agree on ?

Fair enough.

Why are you so against the inline version?

>     Are you fine with below definition ? any other () needed ?
> 
>   #define verbs_set_ctx_op(_vctx, op, ptr) ({ \
>        struct verbs_context *vctx = _vctx; \
>        if (vctx && (vctx->sz >= sizeof(*vctx) - offsetof(struct verbs_context, op))) \
>                vctx->op = ptr; })

This looks fine

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]