[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-raid
Subject:    Re: [PATCH v2] md: avoid invalid memory access for array sb->dev_roles
From:       Song Liu <liu.song.a23 () gmail ! com>
Date:       2019-10-30 23:20:08
Message-ID: CAPhsuW42mg4fo7LvO-t=tdgii8b=u1_b9=05jwZPP4b4eaA97g () mail ! gmail ! com
[Download RAW message or body]

On Wed, Oct 30, 2019 at 3:29 AM Yufen Yu <yuyufen@huawei.com> wrote:
>
> we need to gurantee 'desc_nr' valid before access array
> of sb->dev_roles.
>
> In addition, we should avoid .load_super always return '0'
> when level is LEVEL_MULTIPATH, which is not expected.
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1487373 ("Memory - illegal accesses")
> Fixes: 6a5cb53aaa4e ("md: no longer compare spare disk superblock events in super_load")
> Signed-off-by: Yufen Yu <yuyufen@huawei.com>

Applied to md-next. Thanks for the fix!

Song
[prev in list] [next in list] [prev in thread] [next in thread]