[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-raid
Subject:    Re: [PATCH V3 3/3] Assemble: cleanup the failure path
From:       Jes Sorensen <jes.sorensen () gmail ! com>
Date:       2018-03-08 19:22:56
Message-ID: 7ea7a874-cbfb-8a76-0e9f-1fc2b48bacfd () gmail ! com
[Download RAW message or body]

On 01/22/2018 04:12 AM, Guoqing Jiang wrote:
> There are some failure paths which share common codes
> before return, so simplify them by move common codes
> to the end of function, and just goto out in case
> failure happened.
> 
> Reviewed-by: NeilBrown <neilb@suse.com>
> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
> ---
>  Assemble.c | 62 ++++++++++++++++++++++----------------------------------------
>  1 file changed, 22 insertions(+), 40 deletions(-)

Looks like you got rid of most of the if (locked) cases with this one.

Applied!

Thanks,
Jes

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]