[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ppp
Subject:    Re:Re: [PATCH] driver: ppp: Remove unnecessary bh disable in xmit path
From:       "Gao Feng" <gfree.wind () vip ! 163 ! com>
Date:       2017-06-01 9:48:45
Message-ID: 28d598b9.9c5d.15c630eafb0.Coremail.gfree.wind () vip ! 163 ! com
[Download RAW message or body]

At 2017-06-01 17:07:55, "Guillaume Nault" <g.nault@alphalink.fr> wrote:
>On Thu, Jun 01, 2017 at 09:49:18AM +0800, gfree.wind@vip.163.com wrote:
>> From: Gao Feng <gfree.wind@vip.163.com>
>> 
>> Since the commit 55454a565836 ("ppp: avoid dealock on recursive xmit"),
>> the PPP xmit path is protected by wrapper functions which disable the
>> bh already. So it is unnecessary to disable the bh again in the real
>> xmit path.
>> 
>Looks good, thanks!
>But it seems you forgot to Cc. netdev@vger.kernel.org.
>Please resubmit there.

OK, I resubmit it again.

>
>You can also fix the subject to make clear this patch is for net-next.
>Also, the "driver:" prefix isn't necessary.
>Something like
>[PATCH net-next] ppp: remove unnecessary bh disable in xmit path

No problem, I would follow you.

Regards
Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]