[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ppp
Subject:    problems and questions on ppp 2.4.2 cvs
From:       Clive Nicolson <clive () baby ! bedroom ! gen ! nz>
Date:       2002-10-10 4:15:13
[Download RAW message or body]

While looking at 2.4.2 cvs source I have generated the following notes:

i) auth.c references _linux_ this should be __linux__  !

ii) current_option of options.c is never set, but referenced! Fix this by:

    option_t *mainopt = opt;

    current_option = opt->name;/*<============*/

    if ((opt->flags & OPT_PRIVFIX) && privileged_option)

iii) The callback mechanism is broken, ie no one sets do_callback !

iv) privopen should be local to tty.c ?

v) devstat should be local to tty.c ?

vi) Should "extern int kill_link;" be in ppp.h rather than in ... cf hungup ?

vii) What is the difference between ppp_devnam and devnam ?

vii) Code in tty.c to handle "common" options eg lock/nolock, record should be
moved to a separate file and made global. eg
lock/nolock, lockflag, locked and the code to do the locking and unlocking,
record and start_charshunt etc.

viii) When the call "the_channel->connect()" fails (ie returns -1) how does 
one cause pppd to exit with return code 2 ?

Thanks
Clive

-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]