[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ppc
Subject:    ppc_htab.c l2cr reporting bug
From:       "Timothy A. Seufert" <tas () mindspring ! com>
Date:       1999-04-09 8:49:18
[Download RAW message or body]


There are some bugs in the code which decodes the PPC 750 L2CR
register in ppc_htab.c.  Specifically, some of the lines which
try to extract bit fields from the 32 bit word are bogus.  I
also added decoding of a couple more fields.


------------------cut here-------------------
diff -u -r1.26 ppc_htab.c
--- arch/ppc/kernel/ppc_htab.c	1998/12/10 00:24:23	1.26
+++ arch/ppc/kernel/ppc_htab.c	1999/04/09 04:38:28
@@ -616,7 +616,7 @@
 				break;
 			}
 			
-			switch( (val >> 23) & 0x2 )
+			switch( (val >> 23) & 0x3 )
 			{
 			case 0: p += sprintf(p,",flow-through burst SRAM");
 				break;
@@ -628,11 +628,28 @@
 				break;
 			}
 			
-			p += sprintf(p,"%s",(val>>22)?"":",data only");
-			p += sprintf(p,"%s",(val>>20)?",ZZ enabled":"");
-			p += sprintf(p,",%s",(val>>19)?"write-through":"copy-back");
-			p += sprintf(p,",%sns hold",(val>>16)?"1.0":"0.5");
-			
+			p += sprintf(p,"%s",(val&0x00400000)?"":",data only");
+			p += sprintf(p,"%s",(val&0x00100000)?",auto low-power mode enabled":"");
+			p += sprintf(p,",%s",(val&0x00080000)?"write-through":"copy-back");
+
+			switch( (val >> 16) & 0x3 )
+			{
+			case 0: p += sprintf(p,",0.5ns");
+				break;
+			case 1: p += sprintf(p,",1.0ns");
+				break;
+			case 2:
+			case 3: p += sprintf(p,"unknown");
+				break;
+			}
+			p += sprintf(p," hold");
+
+			p += sprintf(p,",DLL slow mode %s",
+				(val&0x00008000)?"enabled":"disabled");
+
+			p += sprintf(p,",%s clock",
+				(val&0x00004000)?"differential":"single-ended");
+
 			p += sprintf(p,"\n");
 			
 			len = strlen(buf);
------------------cut here-------------------

  Tim Seufert

[[ This message was sent via the linuxppc-dev mailing list.  Replies are ]]
[[ not  forced  back  to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. Please check http://lists.linuxppc.org/ ]]
[[ and http://www.linuxppc.org/ for useful information before posting.   ]]

[prev in list] [next in list] [prev in thread] [next in thread]